fix: [IOPID-1714] IOS crashes on EIC malformed URLs #5660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pagopa-github-bot
changed the title
Affected stories
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5660 +/- ##
==========================================
- Coverage 48.16% 48.15% -0.01%
==========================================
Files 1461 1461
Lines 30971 30966 -5
Branches 7515 7512 -3
==========================================
- Hits 14917 14912 -5
Misses 15986 15986
Partials 68 68
Continue to review full report in Codecov by Sentry.
|
|
@mariateresaventura copy review needed 💪 |
Copy edited. |
|
🎉 All dependencies have been resolved ! |
hevelius
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Warning
This PR depends on pagopa/io-cie-sdk#51
Important
The misleading copy on the error page under the NFC Session Manager is not a subject of this PR.
Tip
Translations ✅
This PR update the
io-cie-sdklibrary to handle malformed responses to avoid crashes on iOS devices in those use cases.demo
RPReplay_Final1712070613.MOV
List of changes proposed in this pull request
LoadingSpinnerOverlay.How to test
Run the app in production with a real iOS device and try to login with EIC several times. No crash'd happen.